Skip to content

Conversation

@mauricefisher64
Copy link
Collaborator

Changes in this pull request

This change add support for C2PA 2.2 changes to how we handle update manifests in for BMFF bases assest.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@mauricefisher64 mauricefisher64 self-assigned this Aug 4, 2025
@mauricefisher64 mauricefisher64 linked an issue Aug 4, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 93.35443% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.22%. Comparing base (c4cfc2a) to head (b7511a7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/asset_handlers/bmff_io.rs 92.65% 13 Missing ⚠️
sdk/src/assertions/bmff_hash.rs 63.63% 4 Missing ⚠️
sdk/src/cose_validator.rs 89.47% 2 Missing ⚠️
sdk/src/store.rs 98.16% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
+ Coverage   78.04%   78.22%   +0.18%     
==========================================
  Files         150      150              
  Lines       38354    38616     +262     
==========================================
+ Hits        29933    30209     +276     
+ Misses       8421     8407      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ok-nick ok-nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few questions. Clever design by the spec too.

@tmathern
Copy link
Contributor

Clippy seems unhappy - not sure if this is due to the Rust update or not (I think not, since it ran after the new Rust version happened?).

Make sure we always recurse ingredient certs
@mauricefisher64 mauricefisher64 merged commit 4c02881 into main Aug 11, 2025
23 checks passed
@mauricefisher64 mauricefisher64 deleted the bmff_update_manifest branch August 11, 2025 14:10
This was referenced Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support C2PA 2.2 BMFF Update Manifest

3 participants