-
Couldn't load subscription status.
- Fork 100
chore: Divide testing into PR validation and release readiness workflows #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR validation (aka "CI") should be MUCH faster now since we're only running on ubuntu-latest.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
- Coverage 80.07% 77.99% -2.08%
==========================================
Files 151 150 -1
Lines 43401 38328 -5073
==========================================
- Hits 34752 29895 -4857
+ Misses 8649 8433 -216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The linux jobs seem to complete pretty quickly, sans the tests using cross. Should we try switching to aarch64 linux runners before removing tests from our PR checks? |
|
@dyro my counter-argument is that we have very few platform-specific issues (except for Wasm/WASI, which are unfortunately slow to run). My goal here is to run as few tests as possible on the fastest possible platform to catch the most common issues. |
|
@scouten-adobe : Understood. I think keeping as much as we can in the PR runner will eliminate headaches when we go to release, especially since our releases can occur far apart from each other. However, I don't do much work in c2pa-rs, so I don't want my opinion to sway the decision to split up our PR checks. Also, I can run the pre-release runner manually when I do contribute 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the makefile so that we have a make ci and make release option, or something along that line, allowing us to pre-check or test locally.
|
@gpeacock as an alternative to your Makefile suggestion, I've added a new label "check-release" which you can apply to any PR to invoke the full release-readiness test suite. (IMHO the Makefile approach is necessarily incomplete because we need to be able to run on multiple platforms and you can't do that on any laptop.) |
…ows (#1281) PR validation (aka "CI") should be MUCH faster now since we're only running on ubuntu-latest.
PR validation (aka "CI") should be MUCH faster now since we're only running on ubuntu-latest.