Skip to content

Conversation

@scouten-adobe
Copy link
Collaborator

PR validation (aka "CI") should be MUCH faster now since we're only running on ubuntu-latest.

PR validation (aka "CI") should be MUCH faster now since we're only running on ubuntu-latest.
@scouten-adobe scouten-adobe self-assigned this Aug 1, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.99%. Comparing base (60001a7) to head (9a9bdec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
- Coverage   80.07%   77.99%   -2.08%     
==========================================
  Files         151      150       -1     
  Lines       43401    38328    -5073     
==========================================
- Hits        34752    29895    -4857     
+ Misses       8649     8433     -216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dyro
Copy link
Contributor

dyro commented Aug 1, 2025

The linux jobs seem to complete pretty quickly, sans the tests using cross. Should we try switching to aarch64 linux runners before removing tests from our PR checks?

@scouten-adobe
Copy link
Collaborator Author

scouten-adobe commented Aug 1, 2025

@dyro my counter-argument is that we have very few platform-specific issues (except for Wasm/WASI, which are unfortunately slow to run). My goal here is to run as few tests as possible on the fastest possible platform to catch the most common issues.

@dyro
Copy link
Contributor

dyro commented Aug 1, 2025

@scouten-adobe : Understood. I think keeping as much as we can in the PR runner will eliminate headaches when we go to release, especially since our releases can occur far apart from each other. However, I don't do much work in c2pa-rs, so I don't want my opinion to sway the decision to split up our PR checks. Also, I can run the pre-release runner manually when I do contribute 👍

Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the makefile so that we have a make ci and make release option, or something along that line, allowing us to pre-check or test locally.

@scouten-adobe
Copy link
Collaborator Author

@gpeacock as an alternative to your Makefile suggestion, I've added a new label "check-release" which you can apply to any PR to invoke the full release-readiness test suite. (IMHO the Makefile approach is necessarily incomplete because we need to be able to run on multiple platforms and you can't do that on any laptop.)

@scouten-adobe scouten-adobe added the check-release Add this label to any PR to invoke a larger suite of tests. label Aug 1, 2025
@scouten-adobe scouten-adobe removed the check-release Add this label to any PR to invoke a larger suite of tests. label Aug 1, 2025
@scouten-adobe scouten-adobe merged commit 14e6127 into main Aug 4, 2025
22 of 23 checks passed
@scouten-adobe scouten-adobe deleted the split-ci-vs-release-readiness branch August 4, 2025 19:33
ok-nick pushed a commit that referenced this pull request Aug 11, 2025
…ows (#1281)

PR validation (aka "CI") should be MUCH faster now since we're only running on ubuntu-latest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants