Skip to content

Conversation

@scouten-adobe
Copy link
Collaborator

No description provided.

@scouten-adobe scouten-adobe requested a review from gpeacock July 29, 2025 15:49
@scouten-adobe scouten-adobe self-assigned this Jul 29, 2025
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.54%. Comparing base (9ce019f) to head (1457f56).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1269   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files         151      151           
  Lines       42722    42722           
=======================================
+ Hits        33982    33983    +1     
+ Misses       8740     8739    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpeacock
Copy link
Collaborator

We can't use the new feature until this pinned test is updated:

  • name: Install Rust toolchain
    uses: dtolnay/rust-toolchain@master
    with:
    toolchain: nightly-2025-01-24
    # Pinning to specific nightly build for now. More recent versions
    # (not sure of start date) cause linker problems with OpenSSL native
    # code on Mac and Windows, but only when built with minimal dependencies.
    # Problem discovered on 2025-01-27.
    # TO DO: Investigate and file bugs if necessary against rust-lang.

Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update this pinned test in ci.yml. It ties us to an older rust version.

https://github.com/contentauth/c2pa-rs/actions/runs/16588277907/job/46917859474?pr=1266

  • name: Install Rust toolchain
    uses: dtolnay/rust-toolchain@master
    with:
    toolchain: nightly-2025-01-24
    # Pinning to specific nightly build for now. More recent versions
    # (not sure of start date) cause linker problems with OpenSSL native
    # code on Mac and Windows, but only when built with minimal dependencies.
    # Problem discovered on 2025-01-27.
    # TO DO: Investigate and file bugs if necessary against rust-lang.

@scouten-adobe
Copy link
Collaborator Author

@gpeacock that test was updated in #1270. Please re-review.

@scouten-adobe scouten-adobe requested a review from gpeacock July 30, 2025 00:17
@scouten-adobe scouten-adobe merged commit 5f8ccf5 into main Jul 30, 2025
38 checks passed
@scouten-adobe scouten-adobe deleted the rust-1.86 branch July 30, 2025 01:44
@caiopensrc caiopensrc mentioned this pull request Jul 30, 2025
ok-nick pushed a commit that referenced this pull request Aug 11, 2025
@caiopensrc caiopensrc mentioned this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants