-
Couldn't load subscription status.
- Fork 100
feat: Bump MSRV to 1.86.0 #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
=======================================
Coverage 79.54% 79.54%
=======================================
Files 151 151
Lines 42722 42722
=======================================
+ Hits 33982 33983 +1
+ Misses 8740 8739 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We can't use the new feature until this pinned test is updated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update this pinned test in ci.yml. It ties us to an older rust version.
https://github.com/contentauth/c2pa-rs/actions/runs/16588277907/job/46917859474?pr=1266
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly-2025-01-24
# Pinning to specific nightly build for now. More recent versions
# (not sure of start date) cause linker problems with OpenSSL native
# code on Mac and Windows, but only when built with minimal dependencies.
# Problem discovered on 2025-01-27.
# TO DO: Investigate and file bugs if necessary against rust-lang.
No description provided.