-
Couldn't load subscription status.
- Fork 100
feat: Remove Send trait for CAIRead on Wasm
#1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`unsafe impl Send` will no longer be required on Wasm. Wasm is single threaded.
Send trait for CAIRead on Wasm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the caveat that all tests & builds should still work after that!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
==========================================
- Coverage 78.05% 78.04% -0.02%
==========================================
Files 150 150
Lines 38354 38354
==========================================
- Hits 29936 29932 -4
- Misses 8418 8422 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Wasm based doctest issues were fixed with #1264
Wasm based doctest issues were fixed with #1264
Changes in this pull request
unsafe impl Sendwill no longer be required on Wasm. Wasm is single threaded.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.