Skip to content

Conversation

@cdmurph32
Copy link
Collaborator

Changes in this pull request

unsafe impl Send will no longer be required on Wasm. Wasm is single threaded.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

`unsafe impl Send` will no longer be required on Wasm. Wasm is single
threaded.
@scouten-adobe scouten-adobe changed the title feat: No Send for CAIRead on wasm feat: Remove Send trait for CAIRead on Wasm Aug 7, 2025
Copy link
Contributor

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that all tests & builds should still work after that!

@cdmurph32 cdmurph32 marked this pull request as ready for review August 7, 2025 16:55
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.04%. Comparing base (47e565b) to head (3cbc9b3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/jumbf_io.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   78.05%   78.04%   -0.02%     
==========================================
  Files         150      150              
  Lines       38354    38354              
==========================================
- Hits        29936    29932       -4     
- Misses       8418     8422       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdmurph32 cdmurph32 merged commit c4cfc2a into main Aug 8, 2025
21 of 23 checks passed
@cdmurph32 cdmurph32 deleted the colmurph_no_send_CAIRead_wasm branch August 8, 2025 00:25
@caiopensrc caiopensrc mentioned this pull request Aug 8, 2025
cdmurph32 added a commit that referenced this pull request Aug 12, 2025
Wasm based doctest issues were fixed with
#1264
@caiopensrc caiopensrc mentioned this pull request Aug 13, 2025
cdmurph32 added a commit that referenced this pull request Aug 13, 2025
Wasm based doctest issues were fixed with
#1264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants