Skip to content

Conversation

@brogdonm
Copy link
Contributor

Changes in this pull request

Give a narrative description of what has been changed.

As denoted in #1243 , the metadata extensions of actions was never fully specified in the documents and therefore can't be truly supported. This PR removes it completely.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@ok-nick ok-nick requested review from gpeacock and ok-nick and removed request for ok-nick July 23, 2025 17:01
@ok-nick
Copy link
Contributor

ok-nick commented Jul 23, 2025

For some additional background, the c2pa docs specify * $$assertion-metadata-map-extension, where * usually signifies any field. In this case, it represents a CDDL group socket where if no socket is specified it means "the choice is empty."

Names that start with a single "$" are "type sockets", starting out
as an empty type, and intended to be extended via "/=". Names that
start with a double "$$" are "group sockets", starting out as an
empty group choice, and intended to be extended via "//=". In either
case, it is not an error if there is no definition for a socket at
all; this then means there is no way to satisfy the rule (i.e., the
choice is empty).

Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misread the spec on this, thanks for the catch. This is technically a breaking change for the API, but I doubt it will effect anything other than our unit tests.

@ok-nick ok-nick merged commit 3f93907 into contentauth:main Jul 24, 2025
36 checks passed
@caiopensrc caiopensrc mentioned this pull request Jul 24, 2025
@vancejc-mt vancejc-mt deleted the fix/1243/removeInvalidGenericMetdata branch July 24, 2025 14:46
@caiopensrc caiopensrc mentioned this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants