feat: Certificate status assertion #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d picture with two ocsp responses
…number, need to figure out how to incorporate into SVI
…ificate serial number
… multiple ocsp_ders
gpeacock
requested changes
Jul 29, 2025
gpeacock
requested changes
Aug 12, 2025
There was a problem hiding this comment.
We need a test that validates that the expected certificate status assertion gets added on signing and that it validates correctly when reading.
Reading validation could be done in a separate PR, but we need to ensure that the assertion is created under the right conditions here.
gpeacock
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Implements the Certificate Status assertion definition and support for checking for certificate revocation from ocsp values found in Certificate Status assertions.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.