feat: Store icon references into c2pa.icon assertions for v2 instead of using data_boxes. #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ison - Enhanced assertion array comparison to report reordering, additions, and removals separately - Added action array comparison for c2pa.actions assertions with same logic - Simplified identifier matching to use only 'label' field for assertions and 'action' field for actions - Both assertion and action comparisons now report: * 'Assertion/Action order changed' when items are reordered * 'Assertion/Action added/removed' when items are added or removed * Individual content changes within matched items - Improved path matching to properly detect actions arrays within assertions - Maintains detailed content comparison for matched items even when reordered
- Fixed duplicate val2.is_null() condition in compare_json_values - Ensured proper detection of content changes within matched assertions/actions - Hash values and other ignorable fields are properly ignored during comparison - Content changes in non-ignorable fields are correctly detected and reported
Update baseline v1
Update known good v2 baseline
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 79.41% 79.26% -0.16%
==========================================
Files 148 148
Lines 41397 41534 +137
==========================================
+ Hits 32877 32923 +46
- Misses 8520 8611 +91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
ok-nick
pushed a commit
that referenced
this pull request
Aug 11, 2025
…of using data_boxes. (#1235) * Improve manifest comparison: better assertion and action array comparison - Enhanced assertion array comparison to report reordering, additions, and removals separately - Added action array comparison for c2pa.actions assertions with same logic - Simplified identifier matching to use only 'label' field for assertions and 'action' field for actions - Both assertion and action comparisons now report: * 'Assertion/Action order changed' when items are reordered * 'Assertion/Action added/removed' when items are added or removed * Individual content changes within matched items - Improved path matching to properly detect actions arrays within assertions - Maintains detailed content comparison for matched items even when reordered * Fix null comparison logic in manifest comparison - Fixed duplicate val2.is_null() condition in compare_json_values - Ensured proper detection of content changes within matched assertions/actions - Hash values and other ignorable fields are properly ignored during comparison - Content changes in non-ignorable fields are correctly detected and reported * fix: Enhance manifest comparison, Update baseline v1 * chore: save v1 json results separately * chore: change make_test_images default to v2 claims Update known good v2 baseline * chore: catch changes in remainder of jumbf urls * chore: clean up clippy errors * feat: generate icons as EmbededData assertions instead data_boxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for 2.2 compliance