Skip to content

Conversation

@cdmurph32
Copy link
Collaborator

Changes in this pull request

The most recent minor version of the image crate (0.25) has the ability to read orientation from EXIF data. This orientation is applied to the pixels of the thumbnail. Minor changes for the new version of the image crate.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

The most recent minor version of the image crate (0.25) has the ability
to read orientation from EXIF data. This orientation is applied to the
pixels of the thumbnail. Minor changes for the new version of the image
crate.
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 95.12195% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.42%. Comparing base (ac4371e) to head (095d548).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/utils/thumbnail.rs 95.12% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
+ Coverage   79.38%   79.42%   +0.03%     
==========================================
  Files         148      148              
  Lines       41294    41397     +103     
==========================================
+ Hits        32781    32878      +97     
- Misses       8513     8519       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdmurph32 cdmurph32 marked this pull request as ready for review July 14, 2025 21:46
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@cdmurph32 cdmurph32 merged commit e44e031 into main Jul 15, 2025
38 checks passed
@cdmurph32 cdmurph32 deleted the fix_jpeg_thumbnail_rotation branch July 15, 2025 14:14
@caiopensrc caiopensrc mentioned this pull request Jul 15, 2025
ok-nick pushed a commit that referenced this pull request Aug 11, 2025
The most recent minor version of the image crate (0.25) has the ability
to read orientation from EXIF data. This orientation is applied to the
pixels of the thumbnail. Minor changes for the new version of the image
crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants