Skip to content

feat: Asset reference assertion #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 18, 2025
Merged

feat: Asset reference assertion #1203

merged 10 commits into from
Jul 18, 2025

Conversation

@alextrnnn
Copy link
Contributor

@alextrnnn alextrnnn commented Jul 7, 2025 •
edited
Loading

Changes in this pull request

Added helper struct for asset reference assertion
Closes #1212

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@alextrnnn alextrnnn requested a review from gpeacock July 7, 2025 16:34
@alextrnnn alextrnnn marked this pull request as ready for review July 7, 2025 16:35
gpeacock
gpeacock requested changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I added a suggestion for a renamed field, even though I can see it isn't public. I'd really like to see an integration level test for this.

@alextrnnn alextrnnn requested a review from gpeacock July 8, 2025 16:15
gpeacock
gpeacock requested changes Jul 9, 2025
View reviewed changes
@alextrnnn alextrnnn requested a review from gpeacock July 11, 2025 15:50
gpeacock
gpeacock requested changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Add the copyright to your source file and we are good to go.

@alextrnnn alextrnnn merged commit d26972c into main Jul 18, 2025
36 checks passed
@alextrnnn alextrnnn deleted the alextrnnn/asset-reference-assertion branch July 18, 2025 22:08
@caiopensrc caiopensrc mentioned this pull request Jul 18, 2025
Merged
@crandmck crandmck added the needs-doc Any change that affects user documentation label Jul 30, 2025
ok-nick pushed a commit that referenced this pull request Aug 11, 2025
@alextrnnn @gpeacock @ok-nick
feat: Asset reference assertion (#1203)
45def66 
* feat: Create asset reference assertion

* docs: Add documentation

* chore: Rename field and add integration test

* format: Fix formatting errors

* fix: Use default version, do not export Reference type to and simplify construction

* chore: Simplify equality tests

* fix: Add copyright

---------

Co-authored-by: Gavin  Peacock <gpeacock@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpeacock gpeacock gpeacock approved these changes

Assignees

No one assigned

Labels

needs-doc Any change that affects user documentation safe to test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Asset Reference Assertion support

4 participants

@alextrnnn @gpeacock @crandmck