Skip to content

Conversation

@fosskers
Copy link
Contributor

@fosskers fosskers commented Jul 3, 2025

Changes in this pull request

This PR bumps the version of nonempty-collections in use, as it was two major versions behind.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.

@fosskers fosskers closed this Jul 3, 2025
@fosskers fosskers reopened this Jul 3, 2025
@scouten-adobe scouten-adobe changed the title chore: bump nonempty-collections chore: Bump nonempty-collections to current version Jul 7, 2025
@scouten-adobe
Copy link
Collaborator

Blocked until we bump MSRV to 1.85. See #1208.

@scouten-adobe
Copy link
Collaborator

scouten-adobe commented Jul 8, 2025

@fosskers this is first-class service 💜 from an open-source developer: Tracking down your dependent crates and offering a PR to update. Thanks and I hope to see you in my GitHub inbox again someday.

Also: Congrats on reaching your 1.0 release.

Happy to merge this!

@scouten-adobe scouten-adobe merged commit 90edb08 into contentauth:main Jul 8, 2025
36 checks passed
@fosskers
Copy link
Contributor Author

fosskers commented Jul 8, 2025

My pleasure. I often see downstream packages hang back a few versions, which I assume is mostly because they didn't notice the x.0.0 or 0.x.0 slots increased and cargo stopped auto-bumping them.

For nonempty-collections specifically, more recent versions changed the underlying representations and improved performance quite a bit.

@fosskers fosskers deleted the colin/bump-nonempty-collections branch July 8, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants