Skip to content

Conversation

@gpeacock
Copy link
Collaborator

@gpeacock gpeacock commented Jun 23, 2025

This is a c2pa 2.2 spec requirement
This now also adds support for the EmbeddedData Assertion - we should be using that for future thumbnail generation.

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

❌ Patch coverage is 89.44954% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.83%. Comparing base (2ab141d) to head (dabf57c).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/assertion.rs 76.00% 6 Missing ⚠️
sdk/src/assertions/thumbnail.rs 81.48% 5 Missing ⚠️
sdk/src/builder.rs 50.00% 5 Missing ⚠️
sdk/src/ingredient.rs 81.81% 4 Missing ⚠️
sdk/src/assertions/embedded_data.rs 96.10% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
+ Coverage   79.57%   79.83%   +0.25%     
==========================================
  Files         147      148       +1     
  Lines       40551    43462    +2911     
==========================================
+ Hits        32268    34696    +2428     
- Misses       8283     8766     +483     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpeacock gpeacock requested review from mauricefisher64 and ok-nick and removed request for ok-nick June 27, 2025 01:40
@tmathern
Copy link
Contributor

Sidenote - you will need a version of #1193 too. Whichever PR pickes it up first and merged first "wins" the right to have more passing checks again.

Copy link
Contributor

@ok-nick ok-nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we already support the __1 naming requirement for v2 ingredient thumbnail labels too?

@gpeacock gpeacock requested a review from ok-nick July 8, 2025 20:43
@gpeacock gpeacock merged commit 95bc8e9 into main Jul 9, 2025
39 checks passed
@gpeacock gpeacock deleted the gpeacock/thumbail_rename branch July 9, 2025 16:54
@caiopensrc caiopensrc mentioned this pull request Jul 9, 2025
@crandmck crandmck added the needs-doc Any change that affects user documentation label Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-doc Any change that affects user documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants