-
Couldn't load subscription status.
- Fork 100
feat: Remove file type from thumbnail names #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 79.57% 79.83% +0.25%
==========================================
Files 147 148 +1
Lines 40551 43462 +2911
==========================================
+ Hits 32268 34696 +2428
- Misses 8283 8766 +483 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sidenote - you will need a version of #1193 too. Whichever PR pickes it up first and merged first "wins" the right to have more passing checks again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we already support the __1 naming requirement for v2 ingredient thumbnail labels too?
…auth/c2pa-rs into gpeacock/thumbail_rename
Implements Thumbnail assertion as Embedded Data. Thumbnail assertion is now only for v1 support. Now use EmbeddedData instead.
This is a c2pa 2.2 spec requirement
This now also adds support for the EmbeddedData Assertion - we should be using that for future thumbnail generation.