refactor: Move uri_to_path into utils #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok-nick
approved these changes
Jun 24, 2025
ok-nick
reviewed
Jul 7, 2025
alextrnnn
force-pushed
the
alextrnnn/refactor-uri-to-path
branch
from
4c47b64 to
c3f54c5
Compare
gpeacock
requested changes
Jul 9, 2025
gpeacock
requested changes
Jul 16, 2025
gpeacock
approved these changes
Jul 18, 2025
Merged
ok-nick
pushed a commit
that referenced
this pull request
Aug 11, 2025
* refactor: Move uri_to_path into utils * fix: Reduce allocations * fix: Return pathbuf directly, add conditional compilation * fix: Remove unused method, modify uri to take Option, resource store uses util * fix: Manifest label replaces colon, and also add test to verify colon replacement * chore: Cleaner import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Move helper method that converts uri to path into utils
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.