fix: Missing symbol from native lib #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmathern
commented
Jun 19, 2025
dyro
approved these changes
Jun 19, 2025
gpeacock
approved these changes
Jun 19, 2025
tmathern
commented
Jun 19, 2025
gpeacock
reviewed
Jun 21, 2025
| _lib.c2pa_manifest_bytes_free(manifest_bytes_ptr) | ||
|
|
||
| return manifest_bytes | ||
| return result |
There was a problem hiding this comment.
how are we going to return the manifest bytes if we throw them away here?
gpeacock
reviewed
Jun 21, 2025
| Returns: | ||
| A tuple of (size of C2PA data, optional manifest bytes) | ||
| Size of C2PA data |
There was a problem hiding this comment.
Sign_file needs to return manifest_bytes so that they can be used for sidecar or uploading remote manifests.
There was a problem hiding this comment.
What is the purpose of returning the size of the manifest_bytes here?
|
|
||
| # Use the sign_file method | ||
| builder = Builder(self.manifestDefinition) | ||
| result = builder.sign_file( |
There was a problem hiding this comment.
This result should be manifest_bytes. Errors should throw.
| @@ -322,13 +322,13 @@ def test_remote_sign(self): | |||
| builder = Builder(self.manifestDefinition) | |||
| builder.set_no_embed() | |||
There was a problem hiding this comment.
typically remote signing would also set_remote_url() If remote fetch is disabled the reader will return an error indicating the RemoteUrl that should be read from. Setting no_embed on its own is mainly there for writing sidecars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122
Fix missing symbol (+add missing test coverage).