-
Notifications
You must be signed in to change notification settings - Fork 10
ci: Update setup for publishing #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gpeacock/py_publish
Are you sure you want to change the base?
Conversation
This reverts commit f1a4ce7.
chore: update to c2pa_rs 0.49.2
fix: c2pa_rs update for dynamic gathered assertions.
@@ -0,0 +1,98 @@ | |||
name: Upload Test for Pypi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Came in when I merged in latest main, did not make changes here in that PR.
python3 ./tests/test_api.py | ||
|
||
publish: release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came in with latest main too
@@ -3,7 +3,7 @@ requires = ["maturin>=1.7.4,<2.0","uniffi_bindgen>=0.28,<0.30"] | |||
build-backend = "maturin" | |||
|
|||
[project] | |||
name = "c2pa" | |||
name = "c2pa-python" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That name needs to match what is in PyPI for Trusted publishing.
|
||
[tool.maturin] | ||
module-name = "c2pa" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we had to update the name above for trusted publishing, now we need this to "fix" the package name.
runs-on: ubuntu-latest | ||
environment: Publish | ||
environment: pypipublish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment needs to match what is set in trusted publishing on PyPI (and it's case-sensitive). Unfortunately, it can do only lower case environments, so the env in github needs to be all lowercase too.
id-token: write | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one more permission so we're sure the token can be used, and the contents we're dealing with, read
Targets #94.
Details about the update are logged in the comments on the PR (see below).
Example runs: