Skip to content

Update Add "Update" to title word list #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update Add "Update" to title word list #599

wants to merge 1 commit into from

Conversation

swadeley
Copy link
Member

Summary

As Konflux opens PRs with title starting "Update" I think we should add it to the allowed list.

Testing steps

peer review & title check test passes

@swadeley swadeley self-assigned this Jul 30, 2025
@dominikvagner
Copy link
Member

dominikvagner commented Jul 30, 2025 •
edited by swadeley
Loading

would this work if the PR title started with Update ... without a colon? 🤔
I think that Konflux doesn't put the colon after the update and the task would still fail on those, am I wrong? 💭

@swadeley swadeley changed the title Update: Add "Update" to title word list Update Add "Update" to title word list Jul 30, 2025
@swadeley
Copy link
Member Author

swadeley commented Jul 30, 2025 •
edited
Loading

would this work if the PR title started with Update ... without a colon? 🤔 I think that Konflux doesn't put the colon after the update and the task would still fail on those, am I wrong? 💭

I will test that now

@swadeley swadeley closed this Jul 30, 2025
@swadeley swadeley reopened this Jul 30, 2025
@swadeley
Copy link
Member Author

would this work if the PR title started with Update ... without a colon? 🤔 I think that Konflux doesn't put the colon after the update and the task would still fail on those, am I wrong? 💭

I will test that now

PR Validation / Title (Successful in 3s)

dominikvagner
dominikvagner approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack! thx! 👍🏼🚀

@swadeley swadeley marked this pull request as draft July 31, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikvagner dominikvagner dominikvagner approved these changes

Assignees

@swadeley swadeley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swadeley @dominikvagner