Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toReadable method #96

Merged
merged 4 commits into from
May 9, 2023
Merged

Add toReadable method #96

merged 4 commits into from
May 9, 2023

Conversation

ausi
Copy link
Member

@ausi ausi commented May 9, 2023

@ausi ausi added the feature label May 9, 2023
@ausi ausi requested a review from Toflar May 9, 2023 14:09
@ausi ausi self-assigned this May 9, 2023
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

/**
* @return array<string,list<string>>
*/
public function toReadable(array $data): array;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of array do I have to expect here? Maybe worth a comment in the interface?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 7c69e59

@ausi ausi requested a review from Toflar May 9, 2023 14:35
@ausi ausi merged commit 13656eb into contao:1.x May 9, 2023
@ausi ausi deleted the fix/metadata-labels branch May 9, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants