Better performance for reading dimensions of SVG images #23
Conversation
|
A quick performance test looks promising:
In comparison reading the size of a jpg/png/gif reaches about 23,500 images/sec. |
I think it is: http://php.net/manual/de/ref.zlib.php#37482 |
|
If we want to be sure we could add an |
|
Maybe in the Contao check or Contao manager but rather not in the core. On a page with 100 images, the check would be executed 100 times otherwise. |
| @@ -176,15 +176,27 @@ public function setImportantPart(ImportantPartInterface $importantPart = null) | |||
| */ | |||
| private function getSvgSize() | |||
| { | |||
| static $zlibSupport; | |||
There was a problem hiding this comment.
Shouldn't this be a static class property such as self::$zlibSupport?
There was a problem hiding this comment.
I don’t think so, because it is only used in this method and nowhere else.
The exception would be if our styleguide doesn’t allow static function variables at all.
There was a problem hiding this comment.
No, our style guide does not forbid to use them.
There was a problem hiding this comment.
Should I keep it as is then?
With this PR
Image::getDimensions()reads SVG files only partially to save IO, parsing time and memory. And it doesn’t callgetimagesize()on SVG images anymore.Todo:
compress.zlib://is supported on all platforms