Extension Manager has problems using php 5.6

[magicsepp]

after selecting an extension f.e. news_sorted there is only a cancel button - the submit button isn't shown.

[03-Sep-2014 07:15:11 GMT] 
PHP Warning: Invalid argument supplied for foreach() in /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/repository/templates/repository_catlist.html5 on line 32
#0 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/repository/templates/repository_catlist.html5(32): __error(2, 'Invalid argumen...', '/mnt/web7/e0/74...', 32, Array)
#1 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/library/Contao/BaseTemplate.php(92): include('/mnt/web7/e0/74...')
#2 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/library/Contao/Template.php(244): Contao\BaseTemplate->parse()
#3 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/classes/BackendTemplate.php(37): Contao\Template->parse()
#4 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/classes/BackendModule.php(102): Contao\BackendTemplate->parse()
#5 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/repository/classes/RepositoryBackendModule.php(72): Contao\BackendModule->generate()
#6 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/repository/classes/RepositoryCatalog.php(43): RepositoryBackendModule->generate()
#7 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/classes/Backend.php(409): RepositoryCatalog->generate()
#8 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/contao/main.php(142): Contao\Backend->getBackendModule('repository_cata...')
#9 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/contao/main.php(293): Main->run()
#10 {main}

[03-Sep-2014 07:15:11 GMT] 
PHP Warning: Invalid argument supplied for foreach() in /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/repository/templates/repository_catlist.html5 on line 68
#0 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/repository/templates/repository_catlist.html5(68): __error(2, 'Invalid argumen...', '/mnt/web7/e0/74...', 68, Array)
#1 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/library/Contao/BaseTemplate.php(92): include('/mnt/web7/e0/74...')
#2 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/library/Contao/Template.php(244): Contao\BaseTemplate->parse()
#3 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/classes/BackendTemplate.php(37): Contao\Template->parse()
#4 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/classes/BackendModule.php(102): Contao\BackendTemplate->parse()
#5 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/repository/classes/RepositoryBackendModule.php(72): Contao\BackendModule->generate()
#6 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/repository/classes/RepositoryCatalog.php(43): RepositoryBackendModule->generate()
#7 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/system/modules/core/classes/Backend.php(409): RepositoryCatalog->generate()
#8 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/contao/main.php(142): Contao\Backend->getBackendModule('repository_cata...')
#9 /mnt/web7/e0/74/51128674/htdocs/contao-4.0.0/contao/main.php(293): Main->run()
#10 {main}```

[tristanlins]

Is it right that you use Contao 4? Than you should make the ticket in this repository: https://github.com/contao/module-repository

[tristanlins]

Okay, this forum user has this problem with Contao 3.3.5
https://community.contao.org/de/showthread.php?52556-(Neu)Installation-unter-Strato-quot-Erweiterungen-nicht-installierbar-quot&p=338997&viewfull=1#post338997

[magicsepp]

Tristan,
the directory is named contao-4.0.0 the version used is the latest 3.3.5 ;)

[tristanlins]

@magicsepp :-P

[leofeyer]

How can this be caused by PHP 5.6? It is about the following lines:

// Zeile 32
<?php foreach ($rep->tags as $tag): ?>

// Zeile 68
<?php foreach ($rep->authors as $aut): ?>

Apparently, $rep->tags and $rep->authors are no longer arrays in PHP 5.6, but they are in PHP 5.5???

[leofeyer]

I have installed PHP 5.6 and I can confirm the issue. However, the error message is just "Bad Request" and that's not helpful at all.

@contao/developers Any ideas?

I figure it must have something to do with the SSL/TLS changes in PHP 5.6:

http://php.net/manual/de/migration56.new-features.php#migration56.new-features.openssl

[leofeyer]

Nope, ruled out the SSL/TLS thing. Also, the first request to $this->client->getExtensionList() works, only the following requests to $this->client->getTagList() and $this->client->getAuthorList() fail.

It might be a PHP bug?

[Toflar]

Is it a matter of the order the calls are executed or a matter of the size of the result set?

[leofeyer]

No idea. PHP only seems to process the first request, independent of the order.

[tristanlins]

So, hab mich dem jetzt auch mal angenommen.
Es wird in RepositoryManager::addActions() Zeile 987 ein getExtensionList call gemacht:

POST /system/modules/rep_server/RepositoryService.php HTTP/1.1
Host: contao.org
Connection: Keep-Alive
User-Agent: PHP-SOAP/5.6.0-1+deb.sury.org~trusty+1
Accept-Encoding: gzip, deflate
Content-Encoding: gzip
Content-Type: application/soap+xml; charset=utf-8; action=""
Content-Length: 339
Cookie: PHPSESSID=e71e20vdd97d85b1teqlqkf8u1;

<?xml version="1.0" encoding="UTF-8"?>
<env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:ns1="http://contao.org/repository"
              xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        >
    <env:Body>
        <ns1:getExtensionList env:encodingStyle="http://www.w3.org/2003/05/soap-encoding">
            <options xsi:type="ns1:extensionListArgs">
                <match xsi:type="xsd:string">exact</match>
                <names xsi:type="xsd:string">composer</names>
                <versions xsi:type="xsd:string">130029</versions>
                <languages xsi:type="xsd:string">de,en</languages>
                <sets xsi:type="xsd:string">dependencies</sets>
            </options>
        </ns1:getExtensionList>
    </env:Body>
</env:Envelope>

(der body ist uncompressed und formatiert)

Dieser endet allerdings in einem bad request:

HTTP/1.1 400 Bad Request
Server: nginx
Date: Thu, 18 Sep 2014 17:34:54 GMT
Content-Type: text/html; charset=utf-8
Content-Length: 166
Connection: close

<html>
<head><title>400 Bad Request</title></head>
<body bgcolor="white">
<center><h1>400 Bad Request</h1></center>
<hr><center>nginx</center>
</body>
</html>

Hier kann ich leider nicht wirklich weiter machen, weil ich nicht weiß wieso ein 400 bad request kommt. @leofeyer vielleicht gibt es da ne Meldung im Server Log? Also prinzipiell sieht der Request eigentlich okay aus.

[discordier]

Mit soapUI bekomme ich tadellos eine Antwort, hab leider kein altes PHP merh hier, muss ich erst noch aufsetzen.

POST http://contao.org/system/modules/rep_server/RepositoryService.php HTTP/1.1
Accept-Encoding: gzip,deflate
Content-Type: text/xml;charset=UTF-8
SOAPAction: ""
Content-Length: 861
Host: contao.org
Connection: Keep-Alive
User-Agent: Apache-HttpClient/4.1.1 (java 1.5)

<soapenv:Envelope xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
xmlns:xsd="http://www.w3.org/2001/XMLSchema" 
xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" 
xmlns:rep="http://contao.org/repository"
xmlns:ns1="http://contao.org/repository"
 >
   <soapenv:Header/>
   <soapenv:Body>
      <rep:getExtensionList soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
            <options xsi:type="ns1:extensionListArgs">
                <match xsi:type="xsd:string">exact</match>
                <names xsi:type="xsd:string">composer</names>
                <versions xsi:type="xsd:string">130029</versions>
                <languages xsi:type="xsd:string">de,en</languages>
                <sets xsi:type="xsd:string">dependencies</sets>
            </options>
      </rep:getExtensionList>
   </soapenv:Body>
</soapenv:Envelope>

Response:

HTTP/1.1 200 OK
Server: nginx
Date: Thu, 18 Sep 2014 17:51:09 GMT
Content-Type: text/xml; charset=utf-8
Content-Length: 1972
Connection: keep-alive
X-Powered-By: PHP/5.5.16
Set-Cookie: PHPSESSID=1tgeghnjepbeck0p6la5mqnp82; path=/; HttpOnly
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache

<?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" xmlns:ns1="http://contao.org/repository" xmlns:SOAP-ENC="http://schemas.xmlsoap.org/soap/encoding/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" SOAP-ENV:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><SOAP-ENV:Body><ns1:getExtensionListResponse><extensions SOAP-ENC:arrayType="ns1:extension[1]" xsi:type="ns1:extensionArray"><item xsi:type="ns1:extension"><totrecs xsi:type="xsd:int">1</totrecs><name xsi:type="xsd:string">composer</name><author xsi:type="xsd:string">cca</author><authorname xsi:type="xsd:string">Contao Community Alliance</authorname><authorsite xsi:type="xsd:string">http://c-c-a.org</authorsite><type xsi:type="xsd:string">free</type><category xsi:type="xsd:string">application</category><version xsi:type="xsd:int">130029</version><build xsi:type="xsd:int">2</build><releasedate xsi:type="xsd:string">1406671200</releasedate><coreminversion xsi:type="xsd:int">20110009</coreminversion><coremaxversion xsi:type="xsd:int">30030049</coremaxversion><downloads xsi:type="xsd:int">236</downloads><installs xsi:type="xsd:int">3780</installs><updates xsi:type="xsd:int">144</updates><votes xsi:type="xsd:int">0</votes><functionality xsi:type="xsd:double">0</functionality><usability xsi:type="xsd:double">0</usability><quality xsi:type="xsd:double">0</quality><rating xsi:type="xsd:double">0</rating><language xsi:type="xsd:string">de</language><title xsi:type="xsd:string">Composer Client Installer</title><teaser xsi:type="xsd:string">Diese Erweiterung wird den Composer Client installieren.</teaser><license xsi:type="xsd:string">LGPL-3.0+</license><translatorname xsi:type="xsd:string">Tristan Lins</translatorname><translatorsite xsi:type="xsd:string">http://bit3.de</translatorsite></item></extensions></ns1:getExtensionListResponse></SOAP-ENV:Body></SOAP-ENV:Envelope>