fix depends on behavior and simplify some of its logic #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #908 +/- ##
=======================================
Coverage ? 42.57%
=======================================
Files ? 24
Lines ? 1388
Branches ? 0
=======================================
Hits ? 591
Misses ? 736
Partials ? 61 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for updating containers in order based on their dependencies had some problems that have been accumulated from various changes, where the full logic wasn't greatly understood.
This PR solves two main reasons why updating linked containers have not been working correctly. It also cleans up the logic and adds more descriptive names to prevent this to happen again.
One scenario that just doesn't make sense is the combination of
rolling-updatesand linked containers, they are now explicitly made mutually exclusive as using them together just causes undefined behaviour,There could be some additional logic added to do a semi-rolling update instead (which is probably what anyone uses these together would expect to happen), but since that logic is not in place, using them together causes a fatal error for now.
Fatal errors should now also correctly be sent through notifications, since watchtower now waits for pending notifications to be sent before exiting.