-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disallow log level 'trace' #765
fix: Disallow log level 'trace' #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #765 +/- ##
=======================================
Coverage ? 43.06%
=======================================
Files ? 24
Lines ? 1356
Branches ? 0
=======================================
Hits ? 584
Misses ? 713
Partials ? 59 Continue to review full report at Codecov.
|
@simskij is there some permission issue with the runner, that my commit failed and yours not? |
@zoispag No, I just fixed the workflow. My commit was mainly meant to trigger a rerun and check if it worked 😅 |
Please update the Wiki at https://containrrr.dev/watchtower/notifications/ to note that trace is disallowed.
|
@harrytheeskimo just a FYI; you can directly suggest an edit by clicking the pen icon in the top right of the documentation! |
@piksel thanks, I did try that at the time yesterday, but the page is restricted:
|
Yeah, the flow is that you make an edit in your fork and then create a PR against this repo. We might need to be clearer about that. Sorry if it tripped you up. |
Closes #759