Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disallow log level 'trace' #765

Merged
merged 4 commits into from
Jan 12, 2021

Conversation

zoispag
Copy link
Member

@zoispag zoispag commented Jan 12, 2021

Closes #759

@zoispag zoispag requested a review from piksel January 12, 2021 12:44
Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@8b95e8c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage        ?   43.06%           
=======================================
  Files           ?       24           
  Lines           ?     1356           
  Branches        ?        0           
=======================================
  Hits            ?      584           
  Misses          ?      713           
  Partials        ?       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b95e8c...ba56d26. Read the comment docs.

@simskij simskij merged commit d04d715 into containrrr:main Jan 12, 2021
@zoispag
Copy link
Member Author

zoispag commented Jan 12, 2021

@simskij is there some permission issue with the runner, that my commit failed and yours not?

@zoispag zoispag deleted the fix/759_dissalow_trace_log_level branch January 12, 2021 19:19
@simskij
Copy link
Member

simskij commented Jan 12, 2021

@zoispag No, I just fixed the workflow. My commit was mainly meant to trigger a rerun and check if it worked 😅

@harrytheeskimo
Copy link

Please update the Wiki at https://containrrr.dev/watchtower/notifications/ to note that trace is disallowed.
It's still shown as an option.

--notifications-level (env. WATCHTOWER_NOTIFICATIONS_LEVEL): Controls the log level which is used for the notifications. If omitted, the default log level is info. Possible values are: panic, fatal, error, warn, info, debug or trace.

@piksel
Copy link
Member

piksel commented Feb 22, 2021

@harrytheeskimo just a FYI; you can directly suggest an edit by clicking the pen icon in the top right of the documentation!

@harrytheeskimo
Copy link

harrytheeskimo commented Feb 22, 2021

@piksel thanks, I did try that at the time yesterday, but the page is restricted:

You need to fork this repository to propose changes.

Sorry, you’re not able to edit this repository directly—you need to fork it and propose your changes from there instead.

@simskij
Copy link
Member

simskij commented Feb 23, 2021

Yeah, the flow is that you make an edit in your fork and then create a PR against this repo. We might need to be clearer about that. Sorry if it tripped you up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting notification-level to trace disables notifications
4 participants