fix: correctly handle non-stale restarts #1220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restarting a container that had dependents, watchtower would previously treat those the same way as stale containers. This means that it would recreate them, even if the necessary information to do so was not present. It also means that it would attempt to clean up the image of the dependent, even though the same image would still be used. This may have been the cause of a number of issues experienced since v1.4.0 was released.
This PR adds checks that makes sure that linked containers also needs a valid config before being stopped, and that their images are only cleaned up if they are actually stale.