archive: improve filter error reporting #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
mtrmac
reviewed
Jul 15, 2024
| func (r *errorRecordingReader) Read(p []byte) (int, error) { | ||
| n, err := r.r.Read(p) | ||
| if err != nil && err != io.EOF { | ||
| r.err = err |
There was a problem hiding this comment.
I think this should prefer the first error, not the last one.
There was a problem hiding this comment.
yes that is better, changed now
There was a problem hiding this comment.
… but still not store err == nil?
There was a problem hiding this comment.
… never mind, this works without an explicit check for err != nil correctly.
follow-up for containers#2012 report the error as seen by the input stream, instead of attempting another read. Closes: containers#2022 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
fix-archive-filter-error-reporting
branch
from
46e36c2
to
91f150f
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up for #2012
report the error as seen by the input stream, instead of attempting another read.
Closes: #2022