Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: drop modprobe calls #2021

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

giuseppe
Copy link
Member

drop an expensive call to "modprobe" each time we initialize the storage. The kernel already tries to automatically load the module if needed, and still the user has the possibility to load the module manually if required.

Alternative fix for: #2019

drop an expensive call to "modprobe" each time we initialize the
storage.  The kernel already tries to automatically load the module if
needed, and still the user has the possibility to load the module
manually if required.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Honny1, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ab74785 into containers:main Jul 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants