Fix the issue where compiling containers-storage with exclude_disk_qu…#1982
Conversation
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
The approach LGTM, just one more cleanup.
(You can force-push over your existing branch instead of opening a new PR.)
b0e8767 to
09e4ed2
Compare
|
Squash your commits and make sure the one commit is signed. git rebase -i origin |
…ota enabled on the Linux CGO platform results in an error indicating that d.quotaCtl.GetDiskUsage is not defined. Signed-off-by: Shi Xue <shixue@cestc.com> Fix the issue where compiling containers-storage with exclude_disk_quota enabled on the Linux CGO platform results in an error indicating that d.quotaCtl.GetDiskUsage is not defined. Signed-off-by: Shi Xue <shixue@cestc.com>
b4ae2f4 to
2c00a5c
Compare
Thank you for your reminder, I have made the modifications as per the standard requirements, thank you again. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, xuegege5290 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @xuegege5290 |
Reference:
#1978 (comment)
To ensure that getComposeFsHelper and others are included, I attempted to move the ReadWriteDiskUsage function from no nocgo into a separate file, creating overlay_disk_quota_unsupported.go. However, the overlay_cgo.go file should not be moved out as it would then be an empty file, and it does not affect the existing logic. What are your thoughts on this modification?
Compile: