Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated use of capability.NewPid (SA1019) #1979

Merged

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Jun 20, 2024

This PR fixes warning deprecated use of capability.NewPid (SA1019) found by golangci when the staticcheck linter is enabled.

Partially fixes:

@Honny1 Honny1 force-pushed the fix-deprecated-capability_NewPid branch from 6e49c10 to 895482c Compare June 20, 2024 14:58
@rhatdan
Copy link
Member

rhatdan commented Jun 20, 2024

/approve
LGTM
@giuseppe @nalind @saschagrunert @mtrmac PTAL

Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Honny1 Honny1 force-pushed the fix-deprecated-capability_NewPid branch 2 times, most recently from a05e98a to 26f2d79 Compare June 20, 2024 15:46
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK to the change itself, just stylistic nits…

pkg/unshare/unshare_linux.go Outdated Show resolved Hide resolved
pkg/unshare/unshare_linux.go Outdated Show resolved Hide resolved
Signed-off-by: Jan Rodák <hony.com@seznam.cz>
@Honny1 Honny1 force-pushed the fix-deprecated-capability_NewPid branch from 26f2d79 to 2e22bd4 Compare June 20, 2024 16:45
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm label Jun 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b885f96 into containers:main Jun 20, 2024
18 checks passed
@Honny1 Honny1 deleted the fix-deprecated-capability_NewPid branch July 1, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants