Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composefs: return mkcomposefs stderr as part of error #1890

Merged
merged 1 commit into from
Apr 18, 2024
Merged

composefs: return mkcomposefs stderr as part of error #1890

merged 1 commit into from
Apr 18, 2024

Commits on Apr 18, 2024

  1. composefs: return mkcomposefs stderr as part of error 

    Writing the error to stderr is not helpful when using the podman API.
The error would only be visable on the server which is bad and likely is
not noticed at all.

Also for the regular podman cli it would be hard for a user to know if
the stderr from mkcompose is related to the returned podman error.

To fix this capture the stderr and append it to the error as string,
this should be fine assuming mkcomposefs doesn't print a ton on stderr
which I assume is not the case.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    @Luap99
    Luap99 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2a4b851 View commit details
    Browse the repository at this point in the history