pkg/archive: avoid user lookups when generating tarball #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
giuseppe
force-pushed
the
archive-ignore-username-groupname
branch
from
3f13337
to
e0bd86a
Compare
|
LGTM |
giuseppe
force-pushed
the
archive-ignore-username-groupname
branch
from
e0bd86a
to
44056d4
Compare
green now |
|
LGTM |
nalind
reviewed
Feb 22, 2024
pkg/archive/archive.go
Outdated
| // sysStatOverride, if non-nil, populates hdr from system-dependent fields of fi. | ||
| var sysStatOverride func(fi os.FileInfo, hdr *tar.Header) error | ||
|
|
||
| func FileInfoHeaderNoLookups(fi os.FileInfo, link string) (*tar.Header, error) { |
There was a problem hiding this comment.
unexported and pushed a new version.
This change introduces a new approach to generating tar headers in a way that avoids system-dependent lookups and potential calls to glibc, enhancing portability and security. The same logic is used by Moby, and the override function is based on code from Moby. Closes: containers#1836 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
archive-ignore-username-groupname
branch
from
44056d4
to
e024854
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new approach to generating tar headers in a way that avoids system-dependent lookups and potential calls to glibc, enhancing portability and security.
The same logic is used by Moby, and the override function is based on code from Moby.
Closes: #1836