chunked: validate converted images

[giuseppe]

validate that the retrieved data for converted images matches the expected digest.

The related change in c/image:

diff --git a/storage/storage_dest.go b/storage/storage_dest.go
index 0cd4392a..56f16461 100644
--- a/storage/storage_dest.go
+++ b/storage/storage_dest.go
@@ -279,7 +279,7 @@ func (s *storageImageDestination) PutBlobPartial(ctx context.Context, chunkAcces
                blobInfo:      srcInfo,
        }
 
-       differ, err := chunked.GetDiffer(ctx, s.imageRef.transport.store, srcInfo.Size, srcInfo.Annotations, &fetcher)
+       differ, err := chunked.GetDiffer(ctx, s.imageRef.transport.store, &srcInfo.Digest, srcInfo.Size, srcInfo.Annotations, &fetcher)
        if err != nil {
                return private.UploadedBlob{}, err
        }

[mtrmac]

Thanks!

I think this works; but really it seems to me that the convert_images boolean (… if it continues to exist in the production version of composefs; I don’t know if that’s the plan) should be handled around the ordinary Store.PutLayer. If nothing else, then it would work with registries which don’t support range requests.

[giuseppe]

@mtrmac thanks for the review.

I've addressed your comments and pushed a new version

[mtrmac]

/lgtm

Thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe,mtrmac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[giuseppe]

thanks! The related change in c/image:

• storage: validate images converted to zstd:chunked image#2243