Skip to content

Fix a typo that breaks build / vedoring #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nalind merged 1 commit into from
Nov 10, 2022
Merged

Fix a typo that breaks build / vedoring #1428

nalind merged 1 commit into from
Nov 10, 2022

Conversation

@mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Nov 10, 2022

In Buildah:

GO111MODULE=on go mod vendor
internal error: failed to find embedded files of github.com/containers/storage/pkg/parsers/kernel: /Users/mitr/Go/pkg/mod/github.com/mtrmac/storage@v0.0.0-20221110150436-c5fb20795713/pkg/parsers/kernel/uname_unsupported.go:8:2: string literal not terminated

@mtrmac
Fix a typo that breaks build / vedoring
9b8be34 
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 10, 2022

@rhatdan @nalind PTAL, #1425 makes the current main of c/storage unusable in dependencies.

nalind
nalind approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@nalind nalind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eek. Approved.

@nalind nalind merged commit 0c062d8 into containers:main Nov 10, 2022
@mtrmac mtrmac deleted the untested-typo branch November 10, 2022 15:33
@mtrmac mtrmac mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nalind nalind nalind approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtrmac @nalind