Cleanup Dockerfile builds #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomSweeneyRedHat PTAL |
|
@rhatdan when are you doing those builds that you're speeding up? Are you pulling the complete image and then building upon it? |
|
And looking at image size, it bumps the stable image from 252MB to 398MB, I'd like to keep it on the lower size, especially since both the Buildah and Podman images are smaller than 398MB. |
|
Wow, lets look at other caches besides dnf. |
|
@TomSweeneyRedHat Your size difference is compressed versus not compressed, definitely not caused by the change. |
|
thx @rhatdan this needs a rebase, once done we can merge this. |
Add `-y` options to yum clean all Only delete below /var/cache/dnf so that I can use the -v /var/cache/dnf:/var/cache/dnf:O option when building to speed up builds. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-yoptions to yum clean allOnly delete below /var/cache/dnf so that I can use the
-v /var/cache/dnf:/var/cache/dnf:O option when building
to speed up builds.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com