Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootc image short-names #55

Merged
merged 1 commit into from
May 13, 2024
Merged

Add bootc image short-names #55

merged 1 commit into from
May 13, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 9, 2024

No description provided.

@rhatdan
Copy link
Member Author

rhatdan commented May 9, 2024

@vrothberg @cgwalters PTAL

shortnames.conf Outdated
@@ -8,6 +8,7 @@
"archlinux" = "docker.io/library/archlinux"
# centos
"centos" = "quay.io/centos/centos"
"centos-bootc" = "quay.io/centos-bootc/centos-bootc"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do this one right now as it is likely to change in the relatively near future by moving to quay.io/centos I hope.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also no :latest version, which will cause tests to fail.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah...that's a legacy of the centos/centos-stream split I think. There is a quay.io/centos/centos:latest but it's actually last built
"Created": "2020-12-08T00:22:53.076477777Z"

Probably it's time to just replace centos:latest with centos:stream9 for now...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who do we contact to get quay.io/centos/centos-bootc in place?

shortnames.conf Outdated
@@ -56,6 +57,7 @@
"rhel7" = "registry.access.redhat.com/rhel7"
"rhel7.9" = "registry.access.redhat.com/rhel7.9"
"rhel-atomic" = "registry.access.redhat.com/rhel-atomic"
"rhel-bootc" = "registry.redhat.io/rhel9/rhel-bootc"
Copy link
Member

@vrothberg vrothberg May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rhel-bootc" = "registry.redhat.io/rhel9/rhel-bootc"
"rhel9-bootc" = "registry.redhat.io/rhel9/rhel-bootc"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have rhel-bootc be equivalent to rhel-bootc:latest and that to shift when RHEL10 is released. But I guess this is a decent compromize for now.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not tie the rhel alias to rhel9

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@@ -56,6 +57,7 @@
"rhel7" = "registry.access.redhat.com/rhel7"
"rhel7.9" = "registry.access.redhat.com/rhel7.9"
"rhel-atomic" = "registry.access.redhat.com/rhel-atomic"
"rhel9-bootc" = "registry.redhat.io/rhel9/rhel-bootc"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I thought originally we'd planned to not have a :latest tag there, but maybe it just happened by default.

@rhatdan rhatdan merged commit c459c87 into containers:main May 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants