-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootc image short-names #55
Conversation
@vrothberg @cgwalters PTAL |
shortnames.conf
Outdated
@@ -8,6 +8,7 @@ | |||
"archlinux" = "docker.io/library/archlinux" | |||
# centos | |||
"centos" = "quay.io/centos/centos" | |||
"centos-bootc" = "quay.io/centos-bootc/centos-bootc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not do this one right now as it is likely to change in the relatively near future by moving to quay.io/centos
I hope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also no :latest version, which will cause tests to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah...that's a legacy of the centos/centos-stream split I think. There is a quay.io/centos/centos:latest
but it's actually last built
"Created": "2020-12-08T00:22:53.076477777Z"
Probably it's time to just replace centos:latest
with centos:stream9
for now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who do we contact to get quay.io/centos/centos-bootc in place?
shortnames.conf
Outdated
@@ -56,6 +57,7 @@ | |||
"rhel7" = "registry.access.redhat.com/rhel7" | |||
"rhel7.9" = "registry.access.redhat.com/rhel7.9" | |||
"rhel-atomic" = "registry.access.redhat.com/rhel-atomic" | |||
"rhel-bootc" = "registry.redhat.io/rhel9/rhel-bootc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"rhel-bootc" = "registry.redhat.io/rhel9/rhel-bootc" | |
"rhel9-bootc" = "registry.redhat.io/rhel9/rhel-bootc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to have rhel-bootc be equivalent to rhel-bootc:latest and that to shift when RHEL10 is released. But I guess this is a decent compromize for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not tie the rhel
alias to rhel9
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@@ -56,6 +57,7 @@ | |||
"rhel7" = "registry.access.redhat.com/rhel7" | |||
"rhel7.9" = "registry.access.redhat.com/rhel7.9" | |||
"rhel-atomic" = "registry.access.redhat.com/rhel-atomic" | |||
"rhel9-bootc" = "registry.redhat.io/rhel9/rhel-bootc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I thought originally we'd planned to not have a :latest
tag there, but maybe it just happened by default.
No description provided.