-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Quadlet - Error when units define User, Group, or DynamicUser in Serv… #26552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quadlet - Error when units define User, Group, or DynamicUser in Serv… #26552
Conversation
dd03f1a to
124f771
Compare
…ice group Fixes: containers#26543 Signed-off-by: Evan Miller <miller.evan815@gmail.com>
124f771 to
4b1f7bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Update: Per discussion, changed to a warning instead of an error. Since initServiceUnitFile doesn't currently log any warnings, rather than refactor a large amount of quadlet.go I lifted the logic out to main.go, similar to the warnIfAmbiguousName func adjacent to it. |
Signed-off-by: Evan Miller <miller.evan815@gmail.com>
d1d8f99 to
31b4efc
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AgentEpsilon, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM. @Luap99 can we merge without these two checks that seem stuck? |
|
yes, we have merge protection for the stuff that is blocking (everything in cirrus basically). The packit tasks are optional. |
c8272b2
into
containers:main
…ice group
Fixes: #26543
Does this PR introduce a user-facing change?