Skip to content

Conversation

@AgentEpsilon
Copy link
Contributor

…ice group

Fixes: #26543

Does this PR introduce a user-facing change?

Added: Quadlet generator will now fail with a descriptive error message if a unit defines User, Group, or DynamicUser in its Service group.
	Users created by systemd in this way this way cannot run podman, so this is an improvement over the current behavior - generating a systemd service that will fail.

@AgentEpsilon AgentEpsilon force-pushed the quadlet-service-unsupported-keys branch from dd03f1a to 124f771 Compare July 2, 2025 05:45
…ice group

Fixes: containers#26543

Signed-off-by: Evan Miller <miller.evan815@gmail.com>
@AgentEpsilon AgentEpsilon force-pushed the quadlet-service-unsupported-keys branch from 124f771 to 4b1f7bc Compare July 2, 2025 07:34
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks overall this seems like a good idea.

@mheon @baude @ygalblum WDYT?

@AgentEpsilon
Copy link
Contributor Author

Update: Per discussion, changed to a warning instead of an error. Since initServiceUnitFile doesn't currently log any warnings, rather than refactor a large amount of quadlet.go I lifted the logic out to main.go, similar to the warnIfAmbiguousName func adjacent to it.

Signed-off-by: Evan Miller <miller.evan815@gmail.com>
@AgentEpsilon AgentEpsilon force-pushed the quadlet-service-unsupported-keys branch from d1d8f99 to 31b4efc Compare July 3, 2025 01:23
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AgentEpsilon, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2025
@ygalblum
Copy link
Contributor

ygalblum commented Jul 4, 2025

LGTM. @Luap99 can we merge without these two checks that seem stuck?

@Luap99
Copy link
Member

Luap99 commented Jul 4, 2025

yes, we have merge protection for the stuff that is blocking (everything in cirrus basically). The packit tasks are optional.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c8272b2 into containers:main Jul 4, 2025
75 of 77 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 3, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quadlets with DynamicUser=yes always fail with "stat /.config: no such file or directory"

3 participants