-
Notifications
You must be signed in to change notification settings - Fork 2.9k
test: Fix for spurious runc error message #26017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix for spurious runc error message #26017
Conversation
Signed-off-by: Ricardo Branco <rbranco@suse.de>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardobranco777 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that raises quite some questions for me. Is that a consistent error or a flake?
A) we should not be printing that error, if forwarding fails and the container is removed already then we should ignore that silently.
B) The test doesn't send any signals AFAIK where does 18 (SIGCONT) come from
C) How are we forwarding/catching SIGCONT? I always thought one cannot catch SIGSTOP/CONT signals.
Overall this feels like a podman bug we should not work around in tests.
It's not consistent. Seems like a flake to me.
Agree. |
If the container is already removed do not log a warning as this happens in parallel so it is possible the container was already removed. The flake was shown in containers#26017. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
Closing in favour of #26027 which should properly address the flake I believe. |
If the container is already removed do not log a warning as this happens in parallel so it is possible the container was already removed. The flake was shown in containers#26017. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Fix issue with
030-runtest when using runc as OCI runtime.OS: podman 5.4.2 / runc 1.2.6 on latest openSUSE Tumbleweed
Verification run: https://openqa.opensuse.org/tests/5029065/file/podman-bats-root-local.tap