-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some debian test fixes #24861
Some debian test fixes #24861
Conversation
Found in debian testing where by default there are no unqualified search registries installed. As such the test failed as the FIXME said. Now there is no need for the test to assume anything. Instead set our own config via CONTAINERS_REGISTRIES_CONF then we can do exact matches, except that env was not read in the shell completion code so move some code around to make it read the var in the same way as podman login/logout. Signed-off-by: Paul Holzinger <git@holzinger.dev>
This test a pretty much useless, it checks that a connection attempt on the default socket fails. But this is incorrect as the socket is outside of the test control as such it might be ready to accept connections as thus the test can fail locally or as reported here in the debian tests. Given that a simple connection fails does not add any value I opted to remove it. Fixes containers#24803 Signed-off-by: Paul Holzinger <git@holzinger.dev>
If the source dir is owned by another user then the test the chown will fail assuming we run the tests rootless. This function is only used by the quadlet tests and for the purpose all we need is to read the files so the simple fix is remove the chown as this should make the tests pass on the special debian gating env. Fixes containers#24802 Signed-off-by: Paul Holzinger <git@holzinger.dev>
When running this test on a system without unqualifiedsearch registries it will fail with a different error causing the test to fail. to avoid that case define our own registries.conf that defines quay.io as registry. This should make the test pass in the debian env. Signed-off-by: Paul Holzinger <git@holzinger.dev>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
see commits, a few fixes to make the test work in the default debian package environment
Does this PR introduce a user-facing change?