[v5.3] Add a Windows Installer patch to avoid unrequested reboots #24840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Adding a patch to the bundle so that the update from previous version (v5.3.1) is a minor update, not a major one. A minor update prevents the full uninstallation of v5.3.1 and an unrequested reboot of the machine. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
When building an installer from main branch, and using it to upgrade the latest Podman release on Windows, a reboot is triggered if WSL is not installed. This is a regression caused by an update of the condition to execute `ForceReboot`. This commit fixes the condition and updates some defaults to make it even more unlikely that reboot happens withtout a specific user request for it. It doesn't fix the v5.3.1 to v5.3.2 upgrade though. v5.3.1 has been released already and this commit doesn't avoid that it triggers a reboot when updated. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
For some reason, after upgrading to WiX v5, the forceReboot action appeared before the Dism actions in the msi InstallExecuteSequence table. As a consequence the user was asked to reboot before WSL or Hyper-V installation and to reboot a second time after their installation. To avoid that the ForceReboot action field `Before=StopServices` is replaced with `After=DismX86` Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
This reverts commit 916b805. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #24827
/assign baude