Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.1.1-rhel] Remove RPM cirrus task #20830

Open
wants to merge 1 commit into
base: v4.1.1-rhel
Choose a base branch
from
Open

[v4.1.1-rhel] Remove RPM cirrus task #20830

wants to merge 1 commit into from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Nov 29, 2023

Does this PR introduce a user-facing change?

None

@cevich PTAL

@lsm5 lsm5 changed the title Remove RPM cirrus task [v4.1.1-rhel] Remove RPM cirrus task Nov 29, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@cevich
Copy link
Member

cevich commented Nov 29, 2023

LGTM.

If it ain't one thing, 'tis another. When I run
podman search --compatible quay.io/libpod/whalesay I get an empty reply. The image exists, so I suspect something on the remote side changed. Wasn't there a quay release/update recently?

I just looked, and on main this test is doing a:
podman search --compatible quay.io/podman/stable which does return results.

So perhaps that's the fix?

@lsm5 lsm5 force-pushed the v4.1.1-rhel-remove-rpm-task branch from 275a74e to 63d6c5b Compare November 30, 2023 09:20
@lsm5
Remove RPM cirrus task
7addbae 
No need to test for Fedora rpm builds on this branch.

This task often ends up causing trouble because of 404 repos of older
Fedoras.

Change image used in tests from libpod/whalesay to podman/stable for
successful tests.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5 lsm5 force-pushed the v4.1.1-rhel-remove-rpm-task branch from 63d6c5b to 7addbae Compare November 30, 2023 13:51
@lsm5
Copy link
Member Author

lsm5 commented Nov 30, 2023

wonder if it's a quay issue itself here.

@cevich
Copy link
Member

cevich commented Nov 30, 2023

In case you missed it in the meeting: Yes, it's quay's fault. It's happening all over the place (other branches).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsm5 @cevich