Skip to content

Conversation

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Nov 15, 2023

... to fix a bug which shows up with Go >= 1.19:
klauspost/pgzip#50

A WIP/proof of concept for https://issues.redhat.com/browse/RHEL-15029 .

Does this PR introduce a user-facing change?

Fixed creating compressed archives when compiled with Go ≥ 1.19.

... to fix a bug which shows up with Go >= 1.19:
klauspost/pgzip#50

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 15, 2023
Someone please revert this once quay search is fixed.

Signed-off-by: Ed Santiago <santiago@redhat.com>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@rhatdan
Copy link
Member

rhatdan commented Nov 17, 2023

/unhold
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2023
@mtrmac
Copy link
Contributor Author

mtrmac commented Nov 20, 2023

Fix confirmed in manual testing.

@giuseppe
Copy link
Member

still a Draft?

@mtrmac
Copy link
Contributor Author

mtrmac commented Nov 21, 2023

RHEL must make a decision whether to accept this backport.

@mtrmac mtrmac changed the title [v3.0.1-rhel] Update to github.com/klauspost/pgzip@v1.2.6 [v3.0.1-rhel] RHEL-17147: Update to github.com/klauspost/pgzip@v1.2.6 Nov 27, 2023
@mtrmac mtrmac marked this pull request as ready for review November 27, 2023 21:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 7dbc120 into containers:v3.0.1-rhel Nov 27, 2023
@mtrmac mtrmac deleted the pgzip-update-3.0.1-rhel branch November 27, 2023 21:14
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants