systemd/generate: change type to notify #10557
Conversation
Change the type of units generated with --new from "forking" to "notify". This brings Podman closer to systemd and opens up Podman to a number of use cases (see containers#5572). Units generated without --new remain with `type=forking`. I experimented a bit with adding a `--sdnotify` flag to `podman start` but it doesn't really work well since we're competing with the default sdnotify mode set during container creation. Fixes: containers#5572 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhatdan PTAL |
|
Want to tackle some issues in the edge space. Mostly polishing the systemd integration and anything related to journald. |
|
@containers/podman-maintainers PTAL |
|
Is this ready? I thought the conmon-based SDNotify implementation was still unmerged, and the default OCI runtime implementation has massive issues and should never be used? |
I think it's ready. With |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Change the type of units generated with --new from "forking" to
"notify". This brings Podman closer to systemd and opens up
Podman to a number of use cases (see #5572).
Units generated without --new remain with
type=forking. Iexperimented a bit with adding a
--sdnotifyflag topodman startbutit doesn't really work well since we're competing with the default
sdnotify mode set during container creation.
Fixes: #5572
Signed-off-by: Valentin Rothberg rothberg@redhat.com