Skip to content

Commit

Permalink
machine: Always use --log-file with gvproxy
Browse files Browse the repository at this point in the history
The logs are not verbose if `--debug` is not set, and very useful to
have if gvproxy exits unexpectedly.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
  • Loading branch information
cfergeau committed Jun 28, 2024
1 parent c86386e commit 0d0418a
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions pkg/machine/shim/networking.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@ func startHostForwarder(mc *vmconfigs.MachineConfig, provider vmconfigs.VMProvid
runDir := dirs.RuntimeDir
cmd.PidFile = filepath.Join(runDir.GetPath(), "gvproxy.pid")

if logrus.IsLevelEnabled(logrus.DebugLevel) {
cmd.LogFile = filepath.Join(runDir.GetPath(), "gvproxy.log")
}
cmd.LogFile = filepath.Join(runDir.GetPath(), "gvproxy.log")

cmd.SSHPort = mc.SSH.Port

Expand Down

0 comments on commit 0d0418a

Please sign in to comment.