Bump release to 5.4.0.1 #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The podman pyproject.toml was updated to fix a packaging issue that prevented the `import podman.api` to work. This caused an issue in the package versioning. Python-podman cannot be bumped to version 5.4.1 since it will try to use the libpod/v5.4.1/ endpoint which is not released yet. Python-podman uses the same versioning scheme and so the package need to add a fourth digi in the version scheme to be released on PyPI. This can be avoided in distribution packages with the option of a new release or a patch downstream, but on GitHub and PyPI this is the workaround. Source for packaging Python software https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers Signed-off-by: Nicola Sella <nsella@redhat.com>
Closed
Contributor
|
@Gauravtalreja1: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gauravtalreja1, inknos, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The podman pyproject.toml was updated to fix a packaging issue that prevented the
import podman.apito work.This caused an issue in the package versioning. Python-podman cannot be bumped to version 5.4.1 since it will try to use the libpod/v5.4.1/ endpoint which is not released yet. Python-podman uses the same versioning scheme and so the package need to add a fourth digi in the version scheme to be released on PyPI. This can be avoided in distribution packages with the option of a new release or a patch downstream, but on GitHub and PyPI this is the workaround.
Source for packaging Python software
https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers