Skip to content

Conversation

@inknos
Copy link
Contributor

@inknos inknos commented Jul 22, 2024

cc: @jwhonce

@jwhonce
Copy link
Member

jwhonce commented Jul 24, 2024

@inknos you missed podman/tests/init.py . The API version is hard coded in the tests to ensure review of the API when changing the version number.

Signed-off-by: Nicola Sella <nsella@redhat.com>
@inknos
Copy link
Contributor Author

inknos commented Jul 26, 2024

you missed podman/tests/init.py . The API version is hard coded in the tests to ensure review of the API when changing the version number.

Thanks Jhon I was actually counting on you because I didn't know what was the issue right away, and I started working on something else.

@jwhonce
Copy link
Member

jwhonce commented Jul 26, 2024

LGTM

@jwhonce
Copy link
Member

jwhonce commented Jul 26, 2024

PTAL @umohnani8

@rhatdan
Copy link
Member

rhatdan commented Jul 27, 2024

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7dbc101 into containers:main Jul 27, 2024
@inknos inknos mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants