Skip to content

feat: avoid print() calls and use logging #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: avoid print() calls and use logging #98

wants to merge 1 commit into from

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Sep 1, 2025

old code still relied on print to sysout
just change everything to direct messages to logging

@tarilabs
feat: avoid print() calls and use logging
0360878 
old code still relied on print to sysout
just change everything to direct messages to logging

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
@tarilabs tarilabs marked this pull request as ready for review September 2, 2025 10:21
@gnaponie
Copy link

gnaponie commented Sep 3, 2025

The change looks good 👍
The only note is that I still see a lot of prints in the tests. Would it be worth changing it there too for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarilabs @gnaponie