-
Notifications
You must be signed in to change notification settings - Fork 115
[skip-ci] RPM: switch default firewall to nftables on EL10+ #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM |
Ephemeral COPR build failed. @containers/packit-build please check. |
ELN failures can be ignored for now. They are fixing ELN to default to dnf5 as we speak. |
Tested on centos stream 10 container image wtih rpm installed from copr build job below. |
# Minimum X.Y dep for aardvark-dns | ||
%define major_minor %((v=%{version}; echo ${v%.*})) | ||
|
||
%if %{defined rhel} && 0%{?rhel} >= 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to confirm the rhel macro is also defined on centos stream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, %{rhel} is also on centos stream as well as Fedora ELN. But %{centos} is only on centos stream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can add a comment in spec if it helps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. PTAL
Re-pushing with a comment. |
set NETAVARK_DEFAULT_FW to nftables on EL10+. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
set NETAVARK_DEFAULT_FW to nftables on EL10+.