Skip to content

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 14, 2024

set NETAVARK_DEFAULT_FW to nftables on EL10+.

@mheon
Copy link
Member

mheon commented May 14, 2024

LGTM

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5
Copy link
Member Author

lsm5 commented May 14, 2024

ELN failures can be ignored for now. They are fixing ELN to default to dnf5 as we speak.

@lsm5 lsm5 marked this pull request as ready for review May 14, 2024 14:51
@lsm5
Copy link
Member Author

lsm5 commented May 14, 2024

[root@7629c3fd2a93 /]# rpm -q netavark
netavark-1.10.1-1.20240514125744608979.pr987.119.ge7ea9b7.el10.x86_64
[root@7629c3fd2a93 /]# /usr/libexec/podman/netavark version
{
  "version": "1.11.0-dev",
  "commit": "14044b1e19f238939aa53f10d9acf02e0da11c49",
  "build_time": "2024-05-14T00:00:00+00:00",
  "target": "x86_64-unknown-linux-gnu",
  "default_fw_driver": "nftables"
}

Tested on centos stream 10 container image wtih rpm installed from copr build job below.

@Luap99 @mheon @jnovy PTAL

# Minimum X.Y dep for aardvark-dns
%define major_minor %((v=%{version}; echo ${v%.*}))

%if %{defined rhel} && 0%{?rhel} >= 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm the rhel macro is also defined on centos stream?

Copy link
Member Author

@lsm5 lsm5 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, %{rhel} is also on centos stream as well as Fedora ELN. But %{centos} is only on centos stream

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can add a comment in spec if it helps

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. PTAL

@lsm5
Copy link
Member Author

lsm5 commented May 14, 2024

Re-pushing with a comment.

set NETAVARK_DEFAULT_FW to nftables on EL10+.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 967304f into containers:main May 14, 2024
@lsm5 lsm5 deleted the rpm-rhel-10 branch May 14, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants