Skip to content

add TDX support #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

add TDX support #92

merged 1 commit into from
Jun 12, 2025

Conversation

jakecorrenti
Copy link
Member

No description provided.

@slp
Copy link
Collaborator

slp commented Apr 11, 2025

We should have two qboot binaries, one for SNP and another for TDX, choosing the right one in Makefile.

@slp
Copy link
Collaborator

slp commented Apr 21, 2025

So far LGTM. Not merging since it's still a draft.

@jakecorrenti jakecorrenti marked this pull request as ready for review April 21, 2025 13:10
@jakecorrenti
Copy link
Member Author

jakecorrenti commented Apr 21, 2025

This is ready to go, I just haven't been able to verify everything still works for SNP since I don't have a machine

cc @tylerfanelli

Adds support for a TDX flavor. Additionally adjusts the qboot binary
locations such that SEV has a different binary than TDX.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Copy link
Member

@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I just want to test with SEV-SNP before giving sign-off approval.

Copy link
Member

@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on SEV-SNP. LGTM!

@jakecorrenti
Copy link
Member Author

@slp is this good to merge?

@slp slp merged commit a70c65d into containers:main Jun 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants