feat: krun_set_rootfs_read_only #347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `krun_set_rootfs_read_only` which affects the `"ro"` or `"rw"` flags being injected into kernel command-line arguments. This should be mutually exclusive from `krun_set_kernel`. I'm happy to refine this to add some validation for that situation. I think I'd have to make the flag an `Option<bool>` or it wouldn't be possible to distinguish someone actively setting the rootfs to rw (by passing `false`) from the default situation in a later call to `krun_set_kernel`. Fixes containers#343 Signed-off-by: Geoffrey Goodman <geoff@goodman.dev>
ggoodman
requested review from
jakecorrenti,
MatiasVara,
mtjhrc,
slp and
tylerfanelli
as code owners
ggoodman
commented
Jun 6, 2025
Comment on lines
+534
to
+536
| kernel_cmdline | ||
| .insert_str(format!("{DEFAULT_KERNEL_CMDLINE} rw")) | ||
| .unwrap(); |
There was a problem hiding this comment.
Since I took rw out of both architectures' DEFAULT_KERNEL_CMDLINE, I figured I had to put it back in here. Not sure how this is consumed though.
|
Thanks for the PR! A couple comments:
|
slp
requested changes
Jun 12, 2025
There was a problem hiding this comment.
- Instead of trusting the guest kernel to not write to the virtiofs-exposed filesystem, we should implement a read-only mode in virtiofs itself, as virtiofsd does.
- For consistency with other changes in the API, instead of adding krun_set_rootfs_read_only we should add krun_set_root2, with an additional bool read_only argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
krun_set_rootfs_read_onlywhich affects the"ro"or"rw"flags being injected into kernel command-line arguments.This should be mutually exclusive from
krun_set_kernel. I'm happy to refine this to add some validation for that situation. I think I'd have to make the flag anOption<bool>or it wouldn't be possible to distinguish someone actively setting the rootfs to rw (by passingfalse) from the default situation in a later call tokrun_set_kernel.Fixes #343