Skip to content

Fail earlier when a layer copy fails #2698

Open
@mtrmac

Description

Currently, if a layer copy while copying an image causes a hard failure, we still continue to copy all other layers to completion, and we only detect the error after all other layer copies finish.

That can probably be improved — on an error, at the very least don’t schedule any layer copies that didn’t yet start. Probably, immediately cancel the context (and then correctly report the right error).

See also the various “This can take quite some time” comments around non-obviously-cancellable io.Copy calls, and look for other relevant locations (e.g. dockerImageSource.GetBlobAt doesn’t do much about cancellation).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    kind/featureA request for, or a PR adding, new functionality

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions