Skip to content

Improve errors reported when pulling encrypted images without decryption #2646

Open
@mtrmac

Description

Right now, pulls of encrypted layers try to decrypt and extract them without handing encrypted data specially, so, we see something including invalid tar header (or, with future #2613, writing blob: layer 0 (blob "sha256:…"/""/"sha256:…") does not match config's DiffID "sha256:…").

That’s valuable for tests because we can ensure that the data really is encrypted, but bad for users.

We should add a “requires decrypted layers” field to private.ImageDestination, and abort a copy before starting to read any layers if isEncrypted and the transport requires decryption.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    kind/featureA request for, or a PR adding, new functionality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions