Skip to content

container: fix another race reading cgroup freeze #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhatdan merged 1 commit into from
Nov 11, 2020
Merged

container: fix another race reading cgroup freeze #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/libcrun/container.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2350,8 +2350,15 @@ libcrun_get_container_state_string (const char *id, libcrun_container_status_t *
ret = libcrun_cgroup_is_container_paused (status->cgroup_path, cgroup_mode, &paused, err);
if (UNLIKELY (ret < 0))
{
/* The cgroup might have been cleaned up by systemd by the time we try to read it, so ignore ENOENT. */
if (status->systemd_cgroup && crun_error_get_errno (err) == ENOENT)
/*
The cgroup might have been cleaned up by the time we try to read it, ignore both
ENOENT and ENODEV:
- ENOENT: if the open(CGROUP_PATH) fails because the cgroup was deleted.
- ENODEV: if the cgroup is deleted between the open and reading the freeze status.
*/

errno = crun_error_get_errno (err);
if (errno == ENOENT || errno == ENODEV)
{
crun_error_release (err);
*container_status = "stopped";
Expand Down