Update container-selinux.8 man page #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
lsm5
reviewed
May 31, 2024
| @@ -1476,6 +1476,7 @@ optional_policy(` | |||
| unconfined_domain(kubelet_t) | |||
| ') | |||
|
|
|||
| manage_chr_files_pattern(container_engine_t, fusefs_t, fusefs_t) | |||
There was a problem hiding this comment.
is this a dup? I see the same line already on 1459
|
Tests failed. @containers/packit-build please check. |
lsm5
reviewed
May 31, 2024
| .PP | ||
| .B STANDARD FILE CONTEXT | ||
|
|
||
| SELinux defines the file context types for the container, if you wanted to | ||
| store files with these types in a different paths, you need to execute the semanage command to specify alternate labeling and then use restorecon to put the labels on disk. | ||
|
|
||
| .B semanage fcontext -a -t container_ro_file_t '/srv/mycontainer_content(/.*)?' | ||
| .B semanage fcontext -a -t container_var_lib_t '/srv/container/content(/.*)?' | ||
| .br | ||
| .B restorecon -R -v /srv/mycontainer_content |
There was a problem hiding this comment.
should this also change to /srv/container/content ?
There was a problem hiding this comment.
Yes this looks like a bug in the tool used to generate the man page.
|
ignore centos stream 9 failure. LGTM overall apart from the couple of comments. Suggestion: Maybe we should consider rewriting the manpage in markdown and have go-md2man or other such tool generate the actual manpage at build time ? |
|
These man pages are autogenerated, based on policy changes and the overall policy on the system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.