In compareImageDestinationManifestEqual, compare full manifests
#510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of digests, making this comparison completely resistant to cryptographic hash function collisions. This also means we don't ignore v2s1 signatures in the comparison; that is unlikely to matter (given decreasing support for v2s1), but only skipping the copy if the destination _exactly_ matches the source, including that signature, is more correct. (Note that we still return copySingleImageResult.manifestDigest; this PR does not change that part.) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 29, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6550 |
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of digests, making this comparison completely resistant to cryptographic hash function collisions.
This also means we don't ignore v2s1 signatures in the comparison; that is unlikely to matter (given decreasing support for v2s1), but only skipping the copy if the destination exactly matches the source, including that signature, is more correct.
(Note that we still return
copySingleImageResult.manifestDigest; this PR does not change that part.)Cc: @lsm5